Respect load strictness when calling load_state_dict #10665
Conversation
Signed-off-by: mikolajblaz <mikolajblaz@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
|
According to @ashors1 this type of change is not needed for NeMo 2.0, so should be ready to go, @dimapihtar can you review? |
I think there was a miscommunication here. This change is needed for NeMo 2.0, but I think we can handle that in a separate PR. |
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
What does this PR do ?
model.dist_ckpt_load_strictnessallows to ignore mismatches during checkpoint loading.Still, loading a state dict can yield errors. This PR ensures this flag is respected also during load_state_dict.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information